Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Fix for Nightmare does not work properly #4702

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

PrabbyDD
Copy link
Contributor

@PrabbyDD PrabbyDD commented Oct 21, 2024

Fix for #4691

What are the changes the user will see?

Nightmare was just not working properly before and hitting the pokemon on improper turns and twice a turn. This fixes that.

Why am I making these changes?

big fix

What are the changes from a developer perspective?

Changed battler tag for nightmare from working after the move to the end of the turn.

Screenshots/Videos

Just when asleep
https://github.com/user-attachments/assets/e9038948-d6ec-4c1b-aa61-8cb36a768965

It works properly when pokemon wakes up and is put back to sleep
https://github.com/user-attachments/assets/60ab9bf9-dbe8-4657-8102-05cee8a0cfdf

How to test the changes?

override files, and new nightmare unit test

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Tempo-anon Tempo-anon merged commit 467841d into pagefaultgames:beta Oct 22, 2024
13 checks passed
@PrabbyDD PrabbyDD deleted the prabbyd4691 branch October 22, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants